feat(circuit-breaker): add job ID + old/new state change to circuit-breaker transition #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stijnmoreels
added
enhancement
✅ Deploy Preview for arcus-messaging canceled.
|
stijnmoreels
commented
Feb 7, 2025
src/Arcus.Messaging.Tests.Integration/MessagePump/Fixture/MockCircuitBreakerEventHandler.cs
Show resolved
Hide resolved
stijnmoreels
changed the title
stijnmoreels
commented
Feb 7, 2025
src/Arcus.Messaging.Pumps.Abstractions/Resiliency/IMessagePumpCircuitBreaker.cs
Outdated
Show resolved
Hide resolved
stijnmoreels
commented
Feb 7, 2025
stijnmoreels
commented
Feb 7, 2025
src/Arcus.Messaging.Tests.Integration/MessagePump/Fixture/MockCircuitBreakerEventHandler.cs
Show resolved
Hide resolved
fgheysels
reviewed
Feb 7, 2025
src/Arcus.Messaging.Pumps.Abstractions/Resiliency/IMessagePumpCircuitBreaker.cs
Outdated
Show resolved
Hide resolved
fgheysels
approved these changes
Feb 10, 2025
fgheysels
approved these changes
Feb 10, 2025
src/Arcus.Messaging.Pumps.Abstractions/Resiliency/IMessagePumpCircuitBreaker.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
ICircuitBreakerEventHandlerimplementations only tookMessagePumpCircuitStateduring the transition of circuit breaker states, there was no easy way to know 1) for which message pump the state was changed and 2) what the original state was.This PR wraps this information in an additional type.